ijuma commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1920195950
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -636,6 +605,15 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) if (nodeId != brokerId) { throw new ConfigException(s"You must set `${KRaftConfigs.NODE_ID_CONFIG}` to the same value as `${ServerConfigs.BROKER_ID_CONFIG}`.") } + if (processRoles.isEmpty) { + throw new ConfigException(s"You must set `${KRaftConfigs.PROCESS_ROLES_CONFIG}`. ZooKeeper mode is not supported.") + } else { + // KRaft-based metadata quorum + if (nodeId < 0) { + throw new ConfigException(s"Missing configuration `${KRaftConfigs.NODE_ID_CONFIG}` which is required " + Review Comment: We also made this mandatory. So, the message should probably reflect that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org