chia7712 commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1926480705
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -221,8 +213,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig: QuotaConfig = _quotaConfig /** ********* General Configuration ***********/ - val brokerIdGenerationEnable: Boolean = getBoolean(ServerConfigs.BROKER_ID_GENERATION_ENABLE_CONFIG) - val maxReservedBrokerId: Int = getInt(ServerConfigs.RESERVED_BROKER_MAX_ID_CONFIG) var brokerId: Int = getInt(ServerConfigs.BROKER_ID_CONFIG) Review Comment: > do you think that we should add a warning message when users use broker.id? To let them know the configuration will be removed in 5.0. `broker.id` is not deprecated in 4.0 (as @ijuma mentioned it needs a KIP), so the warning message is unnecessary to me. I open https://issues.apache.org/jira/browse/KAFKA-18628 to discuss the `broker.id` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
