chia7712 commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1926444843
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -221,8 +213,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig: QuotaConfig = _quotaConfig /** ********* General Configuration ***********/ - val brokerIdGenerationEnable: Boolean = getBoolean(ServerConfigs.BROKER_ID_GENERATION_ENABLE_CONFIG) - val maxReservedBrokerId: Int = getInt(ServerConfigs.RESERVED_BROKER_MAX_ID_CONFIG) var brokerId: Int = getInt(ServerConfigs.BROKER_ID_CONFIG) Review Comment: @FrankYang0529 Let's retain broker.id in issue #18478. Additionally, we should update the documentation to clarify that node.id and broker.id are synonymous. This will help prevent user confusion regarding their relationship. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
