gharris1727 commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1876300879


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##########
@@ -98,6 +118,12 @@ public class ConnectorConfig extends AbstractConfig {
             new InstantiableClassValidator()

Review Comment:
   > I have addressed this for converters and transformations (PR # 3)
   
   Do you mean transformations and predicates? I see that there's some 
validation happening there, but I didn't see anything similar for converters in 
this PR.
   
   > but it's not that straightforward for connector and connector versions
   
   The KIP includes an exception for connector.class; we don't have to provide 
validation or recommendations for that.
   
   We provide validation results for connector.plugin.version, because that's 
going to be the single most useful configuration in this new feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to