snehashisp commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1875792630
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java:
##########
@@ -357,6 +357,10 @@ private <T> Set<PluginDesc<T>> pluginsOfClass(String
classNameOrAlias, Set<Plugi
return plugins;
}
+ public PluginsRecommenders recommender() {
Review Comment:
If we keep this as part of Plugins, then we can avoid the `new
PluginsRecommendors(plugins)` call on every validate. Since the plugins
information, once scanned remains static we don't really need to initialize all
the recommenders again and again. Also, if the plugins can be improved to be
mutable in future it would be easier to revoke the current instance of
recommenders in plugins and generate the new recommender, and have it reflected
across all the uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
