snehashisp commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1876140400
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##########
@@ -98,6 +118,12 @@ public class ConnectorConfig extends AbstractConfig {
new InstantiableClassValidator()
Review Comment:
I have addressed this for converters and transformations (PR # 3), but it's
not that straightforward for connector and connector versions. The return on
validation is a set of config Infos which is a combination of some predefined
ones and ones defined in the connector. If the version is incorrect then the
classloading of the connector itself will fail, so it is unclear as to which
set of config infos we show. If we validate and show the config infos from the
latest version of the connector, with the error attributed to the version
config, the set of configs returned may not be accurate for the version
requested.
One possible way would be to return the common `ConnectorConfig` config def,
but that is not something the API does atm, for instance we could do the same
thing for invalid connector class, but we just throw an exception right now,
which is why I have kept it the same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
