snehashisp commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1876018683
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##########
@@ -70,20 +70,30 @@ public class WorkerConfig extends AbstractConfig {
public static final String CLIENT_DNS_LOOKUP_CONFIG =
CommonClientConfigs.CLIENT_DNS_LOOKUP_CONFIG;
public static final String CLIENT_DNS_LOOKUP_DOC =
CommonClientConfigs.CLIENT_DNS_LOOKUP_DOC;
+ public static final String PLUGIN_VERSION_SUFFIX = "version";
Review Comment:
This should be `plugin.verison`.
I changed it from `version` to `plugin.version` based on a suggestion in the
KIP. I only did it for converters and transformations plugins since in those
the `value.converter` prefix and `version` is passed to validate the connector
config, which can conflict if the converter config def defined it internally.
But `connector.version` is more specific and internal connector config def
should not ideally define it. That said, making it consistent across connector
and converters is good too. Will make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
