dajac commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1821035370
##########
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##########
@@ -36,54 +35,68 @@ import scala.collection.Map
import scala.jdk.CollectionConverters._
@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
-class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstance) {
-
- @ClusterTest(
+@ClusterTestDefaults(
types = Array(Type.KRAFT),
serverProperties = Array(
- new ClusterConfigProperty(key =
GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value =
"classic"),
new ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
new ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "1")
)
+)
+class ConsumerGroupHeartbeatRequestTest(cluster: ClusterInstance) {
+
+ @ClusterTests(value = Array(
+ new ClusterTest(
+ serverProperties = Array(new ClusterConfigProperty(key =
GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value =
"classic")),
+ tags = Array("0")
+ ),
+ new ClusterTest(
+ serverProperties = Array(new ClusterConfigProperty(key =
GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value =
"classic")),
+ tags = Array("1")
+ )
+ )
)
Review Comment:
We don't need to parameterize all the existing tests. How about the
following? We make all the existing tests use the last version (so they
provided the member id). We add one test which ensure that version 0 generate
the member id on the server side. We add one test which ensure that versions >
0 fails if the member id is not provided. This should give us enough coverage.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
