lianetm commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1824460356
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberStateListener.java:
##########
@@ -20,18 +20,18 @@
import java.util.Optional;
/**
- * Listener for getting notified of member ID and epoch changes.
+ * Listener for getting notified of member epoch changes.
*/
public interface MemberStateListener {
/**
- * Called whenever member ID or epoch change with new values received from
the broker or
+ * Called whenever epoch change with new values received from the broker or
* cleared if the member is not part of the group anymore (when it gets
fenced, leaves the
* group or fails).
*
* @param memberEpoch New member epoch received from the broker. Empty if
the member is
* not part of the group anymore.
- * @param memberId Current member ID. Empty if the member is not part
of the group.
+ * @param memberId Current member ID. It won't change until the process
terminated.
Review Comment:
```suggestion
* @param memberId Current member ID. It won't change until the
process is terminated.
```
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberStateListener.java:
##########
@@ -20,18 +20,18 @@
import java.util.Optional;
/**
- * Listener for getting notified of member ID and epoch changes.
+ * Listener for getting notified of member epoch changes.
*/
public interface MemberStateListener {
/**
- * Called whenever member ID or epoch change with new values received from
the broker or
+ * Called whenever epoch change with new values received from the broker or
Review Comment:
```suggestion
* Called whenever epoch changes with new values received from the
broker or
```
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -95,10 +95,9 @@ public class CommitRequestManager implements RequestManager,
MemberStateListener
private Optional<Integer> lastEpochSentOnCommit;
/**
- * Latest member ID and epoch received via the {@link
#onMemberEpochUpdated(Optional, Optional)},
- * to be included in the OffsetFetch and OffsetCommit requests if
present. This will have
- * the latest values received from the broker, or empty of the member is
not part of the
- * group anymore.
+ * The member ID and latest member epoch received via the {@link
MemberStateListener#onMemberEpochUpdated(Optional, String)},
+ * to be included in the OffsetFetch and OffsetCommit requests. This will
have
+ * the latest memberEpoch values received from the broker.
Review Comment:
```suggestion
* the latest memberEpoch value received from the broker.
```
(or simply remove the "value")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
