frankvicky commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1814848836
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1293,17 +1287,16 @@ public void setInflightCommitStatus(final boolean
inflightCommitStatus) {
}
static class MemberInfo {
- Optional<String> memberId;
+ String memberId = "";
Review Comment:
Yes, I think it's very ideal! But after quickly going through
`RequestManagers`, it seems that `MembershipManager` relies on
`CommitRequestManager`. If that's the case, it could be tricky.
https://github.com/apache/kafka/blob/553e6b4c6d912b3b619b5a1a5263b616b6d3f62e/clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManagers.java#L197-L219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
