xijiu opened a new pull request, #16906:
URL: https://github.com/apache/kafka/pull/16906

   See the discussion:  
(https://github.com/apache/kafka/pull/11611#discussion_r772625486)
   
   I did the following three things:
   
   1. Find all the code that has invoked the `init (ProcessorContext, 
StateStore)` method. Actually, it is only called in one test 
class(`MockProcessorContextTest`), then I deleted the relevant test method.
   2. Delete the method `init(ProcessorContext, StateStore)` from the 
`StateStore` and Its implementation classes. If the implementation class 
contains both methods `init(ProcessorContext, StateStore)` and 
`init(StateStoreContext, StateStore)` simultaneously, then delete 
`init(ProcessorContext, StateStore)` directly. If the implementation class only 
contains methods `init(ProcessorContext, StateStore)`, then I create a new 
method `init(StateStoreContext, StateStore)` and copy the relevant code to it. 
There are still many details in the code.
   3. The logic of generation of internal topic names in class 
`TimeOrderedCachingWindowStore` was not repalaced by 
`ProcessorContextUtils#changelogFor`, I moved it over while I was at it.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to