ijuma commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1101481342
##########
core/src/test/scala/unit/kafka/log/LogTestUtils.scala:
##########
@@ -247,7 +246,7 @@ object LogTestUtils {
}
def listProducerSnapshotOffsets(logDir: File): Seq[Long] =
- ProducerStateManager.listSnapshotFiles(logDir).map(_.offset).sorted
+
ProducerStateManager.listSnapshotFiles(logDir).asScala.map(_.offset).sorted.toSeq
Review Comment:
`Buffer` is a `Seq`, but this is probably returning `immutable.Seq`. Since
it's a test, we can leave as is (I hadn't noticed it was a test in the initial
review.
##########
core/src/test/scala/unit/kafka/log/LogTestUtils.scala:
##########
@@ -247,7 +246,7 @@ object LogTestUtils {
}
def listProducerSnapshotOffsets(logDir: File): Seq[Long] =
- ProducerStateManager.listSnapshotFiles(logDir).map(_.offset).sorted
+
ProducerStateManager.listSnapshotFiles(logDir).asScala.map(_.offset).sorted.toSeq
Review Comment:
`Buffer` is a `mutable.Seq`, but this is probably returning `immutable.Seq`.
Since it's a test, we can leave as is (I hadn't noticed it was a test in the
initial review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
