dsmiley commented on code in PR #4715:
URL: https://github.com/apache/solr/pull/4715#discussion_r3739815724
##########
solr/solrj/src/test/org/apache/solr/common/util/EnvUtilsTest.java:
##########
@@ -71,15 +74,14 @@ public void getPropWithCamelCase() {
assertEquals("INFO", EnvUtils.getProperty("solr.logLevel"));
assertEquals("INFO", EnvUtils.getProperty("solr.LogLevel"));
assertEquals(Long.valueOf(1234567890L),
EnvUtils.getPropertyAsLong("solrLong"));
- assertEquals(Boolean.TRUE,
EnvUtils.getPropertyAsBool("solr.alwaysOnTraceId"));
- assertEquals(Boolean.TRUE,
EnvUtils.getPropertyAsBool("solr.always.on.trace.id"));
+ assertEquals(Boolean.TRUE,
EnvUtils.getPropertyAsBool("solr.tracing.always.on.enabled"));
}
@Test
public void testEnvsWithCustomKeyNameMappings() {
// These have different names than the environment variables
assertEquals(ENV.get("SOLR_HOME"), EnvUtils.getProperty("solr.solr.home"));
- assertEquals(ENV.get("SOLR_HOST_ADVERTISE"), EnvUtils.getProperty("host"));
+ assertEquals(ENV.get("SOLR_HOST_ADVERTISE"),
EnvUtils.getProperty("solr.host.advertise"));
Review Comment:
This changed assertion no longer makes sense in this test method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
