epugh commented on code in PR #4715: URL: https://github.com/apache/solr/pull/4715#discussion_r3736694647
########## solr/solrj/src/resources/EnvToSyspropMappings.properties: ########## @@ -11,7 +11,7 @@ SOLR_ALWAYS_ON_TRACE_ID=solr.alwaysOnTraceId SOLR_AUTH_JWT_ALLOW_OUTBOUND_HTTP=solr.auth.jwt.allowOutboundHttp SOLR_HIDDEN_SYS_PROPS=solr.hiddenSysProps SOLR_HOME=solr.solr.home -SOLR_HOST_ADVERTISE=host +SOLR_HOST_ADVERTISE=solr.host.advertise Review Comment: okay, chatted with Claude, and your intuition @msternermxy is right. We don't need `SOLR_HOST_ADVERTISE=solr.host.advertise`, it doesn't hurt anything, but doesn't do anything at all as well. I am checking some other settings in this file as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
