epugh commented on code in PR #4715: URL: https://github.com/apache/solr/pull/4715#discussion_r3735491627
########## solr/solrj/src/resources/EnvToSyspropMappings.properties: ########## @@ -11,7 +11,7 @@ SOLR_ALWAYS_ON_TRACE_ID=solr.alwaysOnTraceId SOLR_AUTH_JWT_ALLOW_OUTBOUND_HTTP=solr.auth.jwt.allowOutboundHttp SOLR_HIDDEN_SYS_PROPS=solr.hiddenSysProps SOLR_HOME=solr.solr.home -SOLR_HOST_ADVERTISE=host +SOLR_HOST_ADVERTISE=solr.host.advertise Review Comment: huh... I was under the impression that this was needed for NON-STANDARD mappings. I will dig in more. I assumed that all caps underscroe would convert. I notice however that we also have SOLR_HIDDEN_SYS_PROPS, and I didn't think it would be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
