HoustonPutman commented on PR #4715: URL: https://github.com/apache/solr/pull/4715#issuecomment-5220678552
So I agree, this should be removed since "host" has been deprecated for a while and now removed. But there are a few places in the code that it needs to be fixed. https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java#L45 https://github.com/apache/solr/blob/main/solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java#L77-L79 https://github.com/apache/solr/blob/main/solr/solrj/src/test/org/apache/solr/common/util/EnvUtilsTest.java#L82 I think those are the last remnants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
