dsmiley commented on PR #4612: URL: https://github.com/apache/solr/pull/4612#issuecomment-4928402876
RE `CoreContainer.getDefaultHttpSolrClient()` yes I'm quite aware of that one. Albeit the callers almost always don't actually care that it's specifically of a Jetty nature. So again, I think modules depending on Solr generally don't care; save to a `HttpSolrClient` type without caring about specifically what subtype it is. Perhaps the return type should be made `HttpSolrClient` and we just accept a bit of casting in rare spots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
