serhiy-bzhezytskyy commented on PR #4612: URL: https://github.com/apache/solr/pull/4612#issuecomment-4926974184
Regarding "Was DAGP useful in this task?" — it helped a bit: finding unused declarations and test-scope mixups that compile fine so you'd never catch them by eye — the unused removals here came from it. And the solrj-streaming experiment above is a good example — it's what tells me the api scope matches what core actually exposes. But it's compile-time only — it can't see runtime usage. It flagged kafka-clients:test as unused, but removing it broke the CrossDC integration tests at runtime (EmbeddedKafkaCluster loads TestCondition from it); only the test run caught it. And the redundant-declaration cleanup was manual — DAGP wants to keep those. So does it bring big value? IMO no. Lucene doesn't use any dependency-analysis plugin and its build is fine. I'd keep it as the opt-in `analyzeDependencies` (not a gate), but fine to drop it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
