dsmiley commented on code in PR #4612:
URL: https://github.com/apache/solr/pull/4612#discussion_r3552128616
##########
gradle/validation/dependencies.gradle:
##########
@@ -112,9 +112,14 @@ allprojects {
// Resolve and update locks only if --write-locks explicitly included
// This may not be the case where this task is added as a dependency,
like for "dependencies" task
project.configurations.findAll {
- // Add any custom filtering on the configurations to be resolved
+ // Add any custom filtering on the configurations to be resolved.
+ // Skip the dependency-analysis plugin's synthetic configurations
(marked with "dagp.*"
+ // attributes); they are not meant to be resolved and would fail
lock-file generation.
+ // Skip spotless's own tool-resolution configurations; their
formatter dependencies
+ // don't belong in the project's dependency lock files.
it.canBeResolved &&
- !it.attributes.keySet().any {attr ->
attr.name.startsWith("dagp.")}
+ !it.attributes.keySet().any {attr ->
attr.name.startsWith("dagp.")} &&
+ !it.name.startsWith("spotless")
Review Comment:
CC @malliaridis you might want to know about this line I added to get
unstable spotless configuration noise out of the lockfile
##########
solr/modules/sql/build.gradle:
##########
@@ -22,9 +22,6 @@ description = 'SQL Module'
dependencies {
implementation platform(project(':platform'))
implementation project(':solr:core')
- implementation project(':solr:solrj')
- implementation project(':solr:solrj-streaming')
Review Comment:
TBH, I want to revisit solrj-streaming being "api" from core. I don't think
it should be.
##########
gradle/validation/dependency-analyze.gradle.kts:
##########
Review Comment:
@malliaridis this PR and another I have will add more Kotlin formatted build
files. Our `.editorconfig` that I contributed says kotlin build files should
have 4-space indentation, despite the general default of 2-space. I simply
did that by observation of your choice. Do you think kotlin build files
**should** be 4-space indented for some reason (why)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
