serhiy-bzhezytskyy commented on PR #4612: URL: https://github.com/apache/solr/pull/4612#issuecomment-4924553484
Folded the redundancy cleanup in here. Removed 24 redundant declarations across 17 modules — the ones core provides via `api` (solrj, solrj-zookeeper, solrj-streaming, api), so modules depending on core don't re-declare them. One more I held off on: core exposes `HttpJettySolrClient` in its public API (e.g. `getDefaultHttpSolrClient()`), and DAGP flags solrj-jetty for `api`. Promoting it would let ~4 more modules drop their solrj-jetty declaration too — but that's an implementation→api promotion, which we said we'd keep out of this PR. Want it in, or leave it? Full `./gradlew test` passes (the one red is the flaky TestGracefulJettyShutdown, unrelated). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
