igiguere commented on PR #3955: URL: https://github.com/apache/solr/pull/3955#issuecomment-3694188089
> > Second, it requires a bit more thinking and refactoring around NodeSystemResponse and the conversion in SystemInfoResponse. So this is not ready for merging. > > Agreed - it'll take some changes in our response model type (or how we're wrapping/using it) to fix that failure. I'm at least passingly familiar with AdminInfoHandler - I can take the failing test from here. > > Other than that failure, we're happy with the state of things here though? If so, I'll merge once I get everything passing and happy. I'm working on improvements in SystemInfoResponse, to map either multi-nodes response, or single node response. The AdminInfoHandler tests pass now. I'm adding a test for my changes. Stay tuned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
