igiguere commented on PR #3955:
URL: https://github.com/apache/solr/pull/3955#issuecomment-3690497532

   @epugh , @gerlowskija 
   Failure in AdminHadlersProxyTest: when all nodes are requested (param: 
nodes=all), the response contains a NamedList of each node.  The name of each 
list is the node's name in "host:port_solr" format (ex: 127.0.0.1:43807_solr). 
   First, I don't think such a name is a valid Json field name (with ':' ? or 
is it?).  
   Second, it requires a bit more thinking and refactoring around 
NodeSystemResponse and the conversion in SystemInfoResponse.
   
   Also notice that the responseHeader is repeated when multiple nodes are 
included in the response.
   
   Example NamedList "toString" output from unit test (added log locally in 
AdminHadlersProxyTest) :
   
   ```
   {responseHeader={status=0, QTime=13}, 
   127.0.0.1:43807_solr=
     {responseHeader={status=0, QTime=2}, 
     mode=solrcloud, 
     zkHost=127.0.0.1:45229/solr, 
     solr_home="/opt/solr",
     core_root="/opt/solr",
     lucene={solr-spec-version=null, solr-impl-version=null, 
lucene-spec-version=10.3.2, lucene-impl-version=10.3.2 
dadfd90b4401947f4d0387669dc94999fbb2c830 - 2025-11-13 10:41:29}, 
     jvm={
       version=21.0.9 21.0.9+10-Ubuntu-124.04, 
       name=Ubuntu OpenJDK 64-Bit Server VM, 
       spec={vendor=Oracle Corporation, 
       name=Java Platform API Specification, version=21}, 
       jre={vendor=Ubuntu, version=21.0.9}, 
       vm={vendor=Ubuntu, name=OpenJDK 64-Bit Server VM, 
version=21.0.9+10-Ubuntu-124.04}, processors=1, 
         memory={free=214.6 MB, total=309.5 MB, max=455.5 MB, used=94.9 MB 
(%20.8), 
         raw={free=225050440, total=324534272, max=477626368, used=99483832, 
used%=20.82879812866613}}, 
       jmx={classpath="..."}
   }}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to