igiguere commented on code in PR #3955: URL: https://github.com/apache/solr/pull/3955#discussion_r2640347749
########## solr/solrj/src/java/org/apache/solr/client/solrj/request/SystemInfoRequest.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.solrj.request; + +import org.apache.solr.client.solrj.SolrRequest; +import org.apache.solr.client.solrj.response.SystemInfoResponse; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.ModifiableSolrParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.NamedList; + +/** Class to get a system info response. */ +public class SystemInfoRequest extends SolrRequest<SystemInfoResponse> { + + private static final long serialVersionUID = 1L; + + private final SolrParams params; + + /** Request to "/admin/info/system" by default, without params. */ + public SystemInfoRequest() { + // TODO: support V2 by default. Requires refactoring throughout the CLI tools, at least + this(CommonParams.SYSTEM_INFO_PATH); + } + + /** + * @param path the HTTP path to use for this request. Supports V1 "/admin/info/system" (default) + * or V2 "/node/system" Review Comment: OK, I can leave out the support for the "old" V2 here... Then, RepositoryManager would have to call the V1 endpoint (like before this PR)... But you say the package-manager only has v2 APIs ? So... what do I do here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
