mlbiscoc commented on code in PR #3955:
URL: https://github.com/apache/solr/pull/3955#discussion_r2640428717
##########
solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java:
##########
@@ -1283,12 +1282,7 @@ private Long getNumCommits(HttpSolrClient sourceClient)
throws SolrServerExcepti
.withConnectionTimeout(15000, TimeUnit.MILLISECONDS)
.withSocketTimeout(60000, TimeUnit.MILLISECONDS)
.build()) {
- var req =
- new GenericSolrRequest(
- SolrRequest.METHOD.GET,
- "/admin/metrics",
- SolrRequest.SolrRequestType.ADMIN,
- SolrParams.of("wt", "prometheus"));
+ var req = new MetricsRequest(SolrParams.of("wt", "prometheus"));
Review Comment:
The metrics handler `/admin/metrics` defaults to prometheus if `wt` isn't
passed. So keeping and/or removing this in shouldn't make a difference. But
also the response parser below is set to prometheus so it goes to the
`PrometheusResponseWriter` where `wt` is technically really set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
