risdenk commented on code in PR #2876:
URL: https://github.com/apache/solr/pull/2876#discussion_r2033086854
##########
gradle/libs.versions.toml:
##########
@@ -311,33 +312,38 @@ decompose-decompose = { module =
"com.arkivanov.decompose:decompose", version.re
decompose-extensions-compose = { module =
"com.arkivanov.decompose:extensions-compose", version.ref = "decompose" }
dropwizard-metrics-core = { module = "io.dropwizard.metrics:metrics-core",
version.ref = "dropwizard-metrics" }
dropwizard-metrics-graphite = { module =
"io.dropwizard.metrics:metrics-graphite", version.ref = "dropwizard-metrics" }
-dropwizard-metrics-jetty10 = { module =
"io.dropwizard.metrics:metrics-jetty10", version.ref = "dropwizard-metrics" }
+dropwizard-metrics-jetty12 = { module =
"io.dropwizard.metrics:metrics-jetty12", version.ref = "dropwizard-metrics" }
+dropwizard-metrics-jetty12-ee10 = { module =
"io.dropwizard.metrics:metrics-jetty12-ee10", version.ref =
"dropwizard-metrics" }
dropwizard-metrics-jmx = { module = "io.dropwizard.metrics:metrics-jmx",
version.ref = "dropwizard-metrics" }
dropwizard-metrics-jvm = { module = "io.dropwizard.metrics:metrics-jvm",
version.ref = "dropwizard-metrics" }
-dropwizard-metrics-servlets = { module =
"io.dropwizard.metrics:metrics-servlets", version.ref = "dropwizard-metrics" }
+dropwizard-metrics-servlets = { module =
"io.dropwizard.metrics:metrics-jakarta-servlets", version.ref =
"dropwizard-metrics" }
Review Comment:
Do we need
https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-jakarta-servlet
instead here?
I'm confused why after 60b6ae3a914ca561ee2ccce92d770b708b78e3a3 we have
Jetty 9.4 dependencies included again.
##########
gradle/libs.versions.toml:
##########
@@ -311,33 +312,38 @@ decompose-decompose = { module =
"com.arkivanov.decompose:decompose", version.re
decompose-extensions-compose = { module =
"com.arkivanov.decompose:extensions-compose", version.ref = "decompose" }
dropwizard-metrics-core = { module = "io.dropwizard.metrics:metrics-core",
version.ref = "dropwizard-metrics" }
dropwizard-metrics-graphite = { module =
"io.dropwizard.metrics:metrics-graphite", version.ref = "dropwizard-metrics" }
-dropwizard-metrics-jetty10 = { module =
"io.dropwizard.metrics:metrics-jetty10", version.ref = "dropwizard-metrics" }
+dropwizard-metrics-jetty12 = { module =
"io.dropwizard.metrics:metrics-jetty12", version.ref = "dropwizard-metrics" }
+dropwizard-metrics-jetty12-ee10 = { module =
"io.dropwizard.metrics:metrics-jetty12-ee10", version.ref =
"dropwizard-metrics" }
dropwizard-metrics-jmx = { module = "io.dropwizard.metrics:metrics-jmx",
version.ref = "dropwizard-metrics" }
dropwizard-metrics-jvm = { module = "io.dropwizard.metrics:metrics-jvm",
version.ref = "dropwizard-metrics" }
-dropwizard-metrics-servlets = { module =
"io.dropwizard.metrics:metrics-servlets", version.ref = "dropwizard-metrics" }
+dropwizard-metrics-servlets = { module =
"io.dropwizard.metrics:metrics-jakarta-servlets", version.ref =
"dropwizard-metrics" }
Review Comment:
Do we need
https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-jakarta-servlet
instead here?
I'm confused why after 60b6ae3a914ca561ee2ccce92d770b708b78e3a3 we have
Jetty 9.4 dependencies included again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
