iamsanjay commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2780686392
Can we remove the `HttpSolrCall` getter from `SolrQueryRequest` along with removing `getReq()` from `HttpSolrCall`? Few more places. HttpSolrCall.java ``` public SolrVersion getUserAgentSolrVersion() { String header = req.getHeader("User-Agent"); if (header == null || !header.startsWith("Solr")) { return null; } try { return SolrVersion.valueOf(header.substring(header.lastIndexOf(' ') + 1)); } catch (Exception e) { // unexpected but let's not freak out assert false : e.toString(); return null; } } ``` CancellableQueryTracker.java `activeQueriesGenerated.put(queryID, req.getHttpSolrCall().getQueryString());` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org