iamsanjay commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2781008247
Thanks! But we should avoid propagating the HttpServletRequest further into the codebase? Ideally, it shouldn’t be part of SolrQueryRequest or exposed beyond Jetty once the request has been processed—that's what I was going for with the earlier suggestion. > Also, can we remove the getHttpSolrCall() method from SolrQueryRequest and drop getReq() from HttpSolrCall as part of that cleanup? It doesn’t have to be part of this change, but maybe something we can consider in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
