bruno-roustant commented on PR #3185: URL: https://github.com/apache/solr/pull/3185#issuecomment-2659768506
Actually in its current state, this PR does not work. The Directory returned by the CachedDirectoryFactory may be different than the Directory cached internally. This results in unclosed directories. One option is to cache using a key including the DirContext. Another option is to rollback the DirContext idea and simply let the caller unwrap the Directory based on its usage. Either by directly calling FilterDirectory.unwrap, or by calling a new method DirectoryFactory.unwrap(Directory). Actually I prefer option two. What do you think @dsmiley ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
