bruno-roustant commented on code in PR #3185:
URL: https://github.com/apache/solr/pull/3185#discussion_r1956348656


##########
solr/core/src/java/org/apache/solr/core/DirectoryFactory.java:
##########
@@ -55,10 +55,16 @@ public abstract class DirectoryFactory implements 
NamedListInitializedPlugin, Cl
   // Absolute.
   protected Path dataHomePath;
 
-  // hint about what the directory contains - default is index directory
+  /** Hint about what the directory contains or what the directory will be 
used for. */
   public enum DirContext {
+    /** Default is index directory. */
     DEFAULT,
-    META_DATA
+    /** Directory containing metadata. */
+    META_DATA,
+    /** Directory used to copy raw files during replication. */
+    REPLICATE,
+    /** Directory used to copy raw files during backup. */
+    BACKUP,

Review Comment:
   I separated REPLICATE and BACKUP because backup requires more inner checksum 
verifications that may need to differentiate the logic between the two. (this 
is the case for encryption where we will need the full-fledged 
EncryptionDirectory to access the checksum inside the encrypted Lucene file).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to