epugh commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1896082729
##########
solr/core/src/java/org/apache/solr/core/CoreDescriptor.java:
##########
@@ -64,7 +63,7 @@ public class CoreDescriptor {
public static final String SOLR_CORE_PROP_PREFIX = "solr.core.";
public static final String DEFAULT_EXTERNAL_PROPERTIES_FILE =
- "conf" + File.separator + "solrcore.properties";
+ Path.of("conf/solrcore.properties").toString();
Review Comment:
is there any chance of different file seperators? I wasn't sure if that
was one reason for using the `File.separator`, like on windows? Or is that one
of the benefits of Path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
