dsmiley commented on code in PR #2809: URL: https://github.com/apache/solr/pull/2809#discussion_r1846642455
########## solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java: ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.llm.embedding; + +import dev.langchain4j.data.embedding.Embedding; +import dev.langchain4j.model.embedding.EmbeddingModel; +import java.lang.reflect.Method; +import java.time.Duration; +import java.util.ArrayList; +import java.util.Map; +import java.util.Objects; +import org.apache.lucene.util.Accountable; +import org.apache.lucene.util.RamUsageEstimator; +import org.apache.solr.llm.store.EmbeddingModelException; + +public class SolrEmbeddingModel implements Accountable { + private static final long BASE_RAM_BYTES = + RamUsageEstimator.shallowSizeOfInstance(SolrEmbeddingModel.class); + private static final String TIMEOUT_PARAM = "timeout"; + private static final String MAX_SEGMENTS_PER_BATCH_PARAM = "maxSegmentsPerBatch"; + private static final String MAX_RETRIES_PARAM = "maxRetries"; + + private final String name; + private final Map<String, Object> params; + private final EmbeddingModel embedder; + private final Integer hashCode; + + public static SolrEmbeddingModel getInstance( + String className, String name, Map<String, Object> params) throws EmbeddingModelException { + try { + EmbeddingModel embedder; + Class<?> modelClass = Class.forName(className); Review Comment: Internal classes are loaded normally without needing Class.forName -- just refer to the class normally. SolrResourceLoader is Solr's custom substitute for Class.forName when a class needs to be loaded dynamically. SolrResourceLoader taken from the SolrCore, as this is ConfigSet related, has access the the class path for this Core, which might not be the same as another core. The only place Class.forName should be used is basically when SolrResourceLoader can't be used for one reason or another, like in SolrJ modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
