alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2478308719
Sure @dsmiley, not in a rush at the moment, I would still like feedback around the: 1) I used inversion of control to integrate support for multiple embedding models with minimal impact on the code. It works and it's decently clean, but I would love your feedback on this 2) Embedding models are accessed through client APIS and http requests are made to embed text using external services. To do that I added security exceptions in both 'solr/server/etc/security.policy' It works but I have no idea if it's acceptable or the best way to do it Sorry @cpoerschke, i didn't notice your PR and re-did the code changes you proposed, but they are in nonetheless :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
