alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2471257341
I've done another round of thinking, polishing and experimenting, my comments follow on the various open topics: ### Tests I spent a good 2-3 hours trying to refactor the tests from the current RestTestBase to SolrJettyTestRule. It proved less intuitive than expected, didn't manage to finish, still a lot of errors, bits of code that were handy in RestTestBase and had to be duplicated, and I couldn't foresee any particular improvement in readability or other benefits. So is this a route we really need to adhere to? Current tests seem decently readable, with a good coverage and easy to extend. Looking around I couldn't find a uniform landscape, different modules use different tests style, so If it's about consistency and we care in uniforming this, maybe it's worth doing in a separate issue and by someone with enough knowledge and focus to do this in a decent timeframe? On the other hand if there are real blockers/wrongdoing with the current tests I am more than happy to fix them. ### FileStore vs ManagedResource Current Requirement: A model is a simple tiny Json that contains the parameter to connect to an embedding service. Discussion: Spent some time offline with David around this topic and it seems using the FileStore could be an overkill for this requirement. I then explored configSets in Solr and how we manage them, including managedResources. In the end, I returned to square 1: the current EmbeddingModelStore is a ManagedResource that supports persistency. The code seems simple and readable enough. So, do we really need to replace it with something else? And in case, what do you think we should replace it with? Let me know your thoughts, and thanks again for the help so far! I believe we are making progress! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
