dsmiley commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2469666128
I suggest registering this query parser as "textEmbedder" but not simply "embed" which is a puzzling word by itself without context aside from it being a query parser. Any way, I contributed improvements to the "filestore" based branch, mostly to SolrEmbeddingModel. More is needed -- in Solr we load classes with SolrResourceLoader and *not* with Class.forName. I realized that things didn't compile even before my changes... tests need work. I'm skeptical "RestTestBase" is an appropriate base test class here. Also SolrJettyTestBase is deprecated; you can just use SolrJettyTestRule. The changes I did will require a cache to be defined in solrconfig.xml but I'd like to later improve it so that it's not needed to be configured (but would in-effect exist). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
