janhoy commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1501026138
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##########
@@ -75,9 +77,16 @@ protected HttpSolrClientJdkImpl(String serverBaseUrl,
HttpSolrClientJdkImpl.Buil
if (builder.sslContext != null) {
b.sslContext(builder.sslContext);
}
+
if (builder.executor != null) {
- b.executor(builder.executor);
+ this.executor = builder.executor;
+ this.shutdownExecutor = false;
+ } else {
+ this.executor =
Executors.newCachedThreadPool(Executors.defaultThreadFactory());
Review Comment:
It would be good to have a clearer distinction between the solrj classes
that are meant for end user consumption vs the ones that are only ever to be
used by the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
