jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1500030227
##########
solr/solrj/src/java/org/apache/solr/client/solrj/embedded/SSLConfigBase.java:
##########
@@ -40,35 +52,75 @@ public SSLConfigBase(
this.trustStorePassword = trustStorePassword;
}
+ /**
+ * If set to false, all other settings are ignored.
+ *
+ * @param useSsl boolean
+ */
public void setUseSSL(boolean useSsl) {
this.useSsl = useSsl;
}
+ /**
+ * Set whether client authentication should be requested. If set to false,
truststore settings are
+ * ignored.
+ *
+ * @param clientAuth boolean
+ */
public void setClientAuth(boolean clientAuth) {
this.clientAuth = clientAuth;
}
- /** All other settings on this object are ignored unless this is true */
+ /**
+ * All other settings on this object are ignored unless this is true
+ *
+ * @return boolean
Review Comment:
I removed `SSLConfigBase` and reverted `SSLConfig` back. My initial thought
is the base class could be shared between the two clients but it did not work
out that way. Now we need not worry about the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
