hossman commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1361110252
########## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ########## @@ -250,6 +250,7 @@ If `true` the states of individual replicas will be maintained as individual chi + Set core property _name_ to _value_. See the section xref:configuration-guide:core-discovery.adoc[] for details on supported properties and values. Review Comment: i haven't had a chance to review the code, but this comment regarding testing (that arbitrary key=val options can be set values and actually impact the code) caught my eye. the most straight forward way i can think of to test this would be with a custom config set that refrences those custom values in a way that's trivial to inspect (either from the CoreContainer or via request handler defaults that you could ask each replica for via an `echoParams=all&distrib=false` request) A quick grep suggests we already have a `cloud-minimal-userproperties` configset with `my.custom.prop` added by SOLR-16678 that' seems to exist exactly for this sort of purpose ... the tests added by that jira just don't check the 'persistence" aspect that this PR aims to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
