dsmiley commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1361088912
########## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ########## @@ -250,6 +250,7 @@ If `true` the states of individual replicas will be maintained as individual chi + Set core property _name_ to _value_. See the section xref:configuration-guide:core-discovery.adoc[] for details on supported properties and values. Review Comment: Your tests show arbitrary key-value. Albeit your test doesn't show using them. Hmmm. I was thinking, maybe set `solr.directoryFactory` to `solr.MMapDirectoryFactory` (instead of the default NRT one) and then somehow detect it worked. But this seems hard as Solr doesn't return it (AFAICT) although it prints some derivative info in the searcher stats that kind of reveals the choice. Maybe if you were to add a static inner class superclass to another implementation (like solr.MMapDirectoryFactory) as pass-through, you could then check via some static boolean or something that it was instantiated? Should be really short & simple. For the value of the property, specify the full class name; can't use "solr." prefix/macro. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
