dsmiley commented on code in PR #1973:
URL: https://github.com/apache/solr/pull/1973#discussion_r1361049769
##########
solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java:
##########
@@ -125,6 +125,13 @@ public ZkWriteCommand createCollection(ClusterState
clusterState, ZkNodeProps me
collectionProps.put(ZkStateReader.CONFIGNAME_PROP, configName);
}
+ // add user-defined properties
+ for (String prop : message.keySet()) {
Review Comment:
ooooh, yeah okay, never mind. Seeing "keySet" made me think message was a
Map but it is not, it just has some similar methods. A separate and welcome
change would be to add forEach to ZkNodeProps (judging from some usages of
keySet I see now). But not here in this PR; just a minor improvement idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
