pvcnt opened a new pull request, #1973: URL: https://github.com/apache/solr/pull/1973
https://issues.apache.org/jira/browse/SOLR-17006 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description CREATE collection and ADDREPLICA commands both accept core properties (as property.* parameters) that are then added to the core.properties file. However, those additional properties are not persisted anywhere in the cluster state. Consequently, cores that are added later to a collection (e.g., by adding a new replica) do not contain those properties, which seems inconsistent. I would like to be able to specify a core property when creating a collection, and not repeat myself when adding a new replica later on. # Solution This PR stores core properties in the cluster state for collections and replicas (which also allows them to be queried by plugins, if required). It also apply collection-level core properties to cores created when adding a new replica. **It might be a breaking change if people do not expect this behaviour.** # Tests New tests were added for CREATE collection and ADDREPLICA with core properties. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
