epugh commented on code in PR #1338:
URL: https://github.com/apache/solr/pull/1338#discussion_r1104957402
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -151,9 +152,9 @@ public static class Builder {
protected Http2SolrClient.Builder internalClientBuilder;
private RequestWriter requestWriter;
private ResponseParser responseParser;
- private long retryExpiryTime =
+ private long retryExpiryTimeNano =
TimeUnit.NANOSECONDS.convert(3, TimeUnit.SECONDS); // 3 seconds or 3
million nanos
- private int timeToLiveSeconds = 60;
+ private long timeToLiveSeconds = TimeUnit.SECONDS.convert(60,
TimeUnit.SECONDS);
Review Comment:
mostly to always use the same pattern... Though the more I look at it...
The funnier maybe it is... Is there a pattern like "TimeUnit.SECONDS(60)"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
