stillalex commented on code in PR #1338:
URL: https://github.com/apache/solr/pull/1338#discussion_r1104752653
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java:
##########
@@ -80,8 +81,8 @@ public class LBHttpSolrClient extends LBSolrClient {
private final HttpSolrClient.Builder httpSolrClientBuilder;
private volatile Set<String> urlParamNames = new HashSet<>();
- private Integer connectionTimeout;
- private volatile Integer soTimeout;
+ private Long connectionTimeoutMillis;
+ private volatile Long soTimeoutMillis;
Review Comment:
this does not need to be volatile anymore. it only comes from the builder
there are no setters. it is equivalent to connectionTimeoutMillis, they both
have the same access pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
