dsmiley commented on code in PR #1338:
URL: https://github.com/apache/solr/pull/1338#discussion_r1104915599


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java:
##########
@@ -454,7 +457,7 @@ public NamedList<Object> request(final SolrRequest<?> 
request, String collection
             } else {
               long currentStallTime =
                   TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - 
lastStallTime);
-              if (currentStallTime > stallTime) {
+              if (currentStallTime > stallTimeMillis) {

Review Comment:
   And this will go away eventually as setPollQueueTime is deprecated :-). We 
could make the field volatile but as long as we don't use it within Solr 
anywhere and it's deprecated, I think it's fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to