epugh commented on code in PR #1338:
URL: https://github.com/apache/solr/pull/1338#discussion_r1104770485
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##########
@@ -328,21 +329,22 @@ public Builder(Http2SolrClient http2Client, String...
baseSolrUrls) {
* LBHttpSolrServer keeps pinging the dead servers at fixed interval to
find if it is alive. Use
* this to set that interval
*
- * @param aliveCheckInterval time in milliseconds
+ * @param aliveCheckInterval how often to ping for aliveness
*/
- public LBHttp2SolrClient.Builder setAliveCheckInterval(int
aliveCheckInterval) {
+ public LBHttp2SolrClient.Builder setAliveCheckInterval(int
aliveCheckInterval, TimeUnit unit) {
if (aliveCheckInterval <= 0) {
throw new IllegalArgumentException(
"Alive check interval must be " + "positive, specified value = " +
aliveCheckInterval);
}
- this.aliveCheckInterval = aliveCheckInterval;
+ this.aliveCheckIntervalMillis =
TimeUnit.MILLISECONDS.convert(aliveCheckInterval, unit);
+ ;
Review Comment:
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
