dimas-b commented on code in PR #4117: URL: https://github.com/apache/polaris/pull/4117#discussion_r3033697347
########## polaris-core/src/main/java/org/apache/polaris/core/catalog/LocalCatalogFactory.java: ########## @@ -16,12 +16,12 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.polaris.service.context.catalog; +package org.apache.polaris.core.catalog; Review Comment: Re: `FederatedCatalogFactory`, I believe it also belongs with the "service" SPI, not "core" SPI. I suppose the only reason it is defined in `polaris-core` is to allow simpler reuse in exception modules (Hadoop, Hive). IMHO, this only emphasizes the need to accelerate the SPI discussion and cleanup module dependencies with a coherent SPI definition (modularization) strategy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
