flyrain commented on code in PR #4117: URL: https://github.com/apache/polaris/pull/4117#discussion_r3031014602
########## polaris-core/src/main/java/org/apache/polaris/core/catalog/LocalCatalogFactory.java: ########## @@ -16,12 +16,12 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.polaris.service.context.catalog; +package org.apache.polaris.core.catalog; Review Comment: Here are two reasons I moved it: 1. Be consistent with the `FederatedCatalogFactory` in https://github.com/apache/polaris/pull/4116, `core` owns the abstraction, `service/extensions` own the implementations. 2. It isn’t because `polaris-core` needs to call it directly. It’s because the interface itself is a contract/SPI boundary, and that contract is expressed entirely in core types (`PolarisResolutionManifest`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
