flyrain opened a new pull request, #4117: URL: https://github.com/apache/polaris/pull/4117
Polaris currently uses external catalog for two different ideas: the broad concept of catalogs whose source of truth lives outside Polaris, and the narrower runtime path where Polaris builds a remote catalog client from ConnectionConfigInfo and delegates operations to it. That makes the current SPI name misleading, since notification-synced catalogs are also external in the broad sense but do not use this factory. Likewise, CallContextCatalogFactory describes an implementation detail rather than the role of the abstraction. This PR makes that split explicit by renaming the remote delegation path to FederatedCatalogFactory and the Polaris-managed path to LocalCatalogFactory. That gives us clearer terminology: external stays the umbrella concept, federated refers to remote-backed execution, and local refers to the in-process Polaris-backed path. No behavioral change is intended. This PR also moves the local catalog factory interface into polaris-core. The contract depends only on core concepts, and keeping it in core should make future SPI enforcement simpler if we treat interfaces in polaris-core as the supported SPI surface. ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
