jbonofre commented on code in PR #4117:
URL: https://github.com/apache/polaris/pull/4117#discussion_r3031665722
##########
polaris-core/src/main/java/org/apache/polaris/core/catalog/LocalCatalogFactory.java:
##########
@@ -16,12 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.polaris.service.context.catalog;
+package org.apache.polaris.core.catalog;
import org.apache.iceberg.catalog.Catalog;
import org.apache.polaris.core.persistence.resolver.PolarisResolutionManifest;
-public interface CallContextCatalogFactory {
+public interface LocalCatalogFactory {
Review Comment:
nit: I was a bit confused by the PR title and the actual change - The PR
title says "Move CallContextCatalogFactory to core module" but it also renames
to `LocalCatalogFactory`. The title should reflect both the move and the rename.
##########
polaris-core/src/main/java/org/apache/polaris/core/catalog/LocalCatalogFactory.java:
##########
@@ -16,12 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.polaris.service.context.catalog;
+package org.apache.polaris.core.catalog;
Review Comment:
`PolarisLocalCatalogFactory` stays in
`org.apache.polaris.service.context.catalog` while the interface moved to
`org.apache.polaris.core.catalog`.
This is fine (implementation in service, SPI in core), but the old package
`context.catalog` now only has `PolarisLocalCatalogFactory` and
`RealmContextHolder` — worth noting if future cleanup consolidates packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
