flyrain opened a new pull request, #4116:
URL: https://github.com/apache/polaris/pull/4116
Rename ExternalCatalogFactory to FederatedCatalogFactory because "external
catalog" is a broader concept than what this interface represents. An external
catalog can be either:
1. A federated catalog โ Polaris connects to a remote catalog service
(Iceberg REST, Hive, Hadoop) and delegates operations to it via a
ConnectionConfigInfo.
2. A notification-synced catalog โ Polaris manages tables locally that are
synced via the notification API, with no remote connection involved.
This factory interface only applies to the first case: it takes a
ConnectionConfigInfoDpo and creates a remote catalog handle. Naming it
ExternalCatalogFactory incorrectly implies
it covers all external catalog types. FederatedCatalogFactory makes the
scope clear and is consistent with its existing implementations
(HiveFederatedCatalogFactory,
HadoopFederatedCatalogFactory).
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected])
- [ ] ๐ Clearly explained why the changes are needed, or linked related
issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and
explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
