PhillHenry commented on code in PR #3729:
URL: https://github.com/apache/polaris/pull/3729#discussion_r3022761516
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/iceberg/IcebergRestConnectionConfigInfoDpo.java:
##########
@@ -72,6 +87,12 @@ public String getRemoteCatalogName() {
}
// Add authentication-specific metadata (non-credential properties)
properties.putAll(getAuthenticationParameters().asIcebergCatalogProperties(credentialManager));
+ if (getConfigs().containsKey(GOOGLE_USER_PROJECT_HEADER_KEY)) {
+ properties.put(
+ "header." + GOOGLE_USER_PROJECT_HEADER_KEY,
Review Comment:
@dimas-b As I understand it (and I might totally have it wrong), I don't see
why the project should be in the Spark config as this is a property that's used
by Polaris not the Spark client. The end user might not even be using Spark...
But I emphasise that the subtleties here are currently beyond my ken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
